-
Notifications
You must be signed in to change notification settings - Fork 17
add binder badge to readme #3967
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3967 +/- ##
==========================================
+ Coverage 45.89% 45.94% +0.04%
==========================================
Files 123 123
Lines 29066 29791 +725
==========================================
+ Hits 13340 13687 +347
- Misses 15726 16104 +378 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
8d0c8f7 to
a9877c4
Compare
timothy-nunn
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
8c26c03 to
8c61f22
Compare
8c61f22 to
31907e4
Compare
process/io/plot_proc.py
Outdated
| # Current drive | ||
| # plot_current_drive_info(fig1.add_subplot(236), m_file_data, scan) | ||
| fig1.subplots_adjust(wspace=0.25, hspace=0.25) | ||
| plot_current_drive_info(figs[1].add_subplot(236), m_file_data, scan) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure why this was commented out on main ? I can comment back out/remove if needed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@chris-ashe any idea?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Spoke with @chris-ashe and have commented it back out in this PR
|
I have removed the need for This also solves #3981 : |
je-cook
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few things here and there but overall looks good
add back in bit of docs i removed and correct it
timothy-nunn
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Happy with the code changes, it works locally.
I need your help testing on binder before I approve



Description
Adds a binder badge to the README - when clicked takes you to the binder site which renders PROCESS online, allowing the examples to be run there. Also added some instructions to the README and the docs to explain.
Checklist
I confirm that I have completed the following checks: