Skip to content

Correct file permission handling #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
timothy-nunn merged 1 commit into from
Nov 7, 2025
Merged

Correct file permission handling #9

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions src/hards/filesystem.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,7 +196,7 @@ def get_file(self, name: str) -> Path:
return location

def add_file(
self, file: Path, *, name: str | None = None, permissions: int | None = None
self, file: Path, *, name: str | None = None, permissions: int = 0o400
) -> None:
super().add_file(file, name=name)
if not file.exists() or not file.is_file:
Expand All @@ -209,9 +209,11 @@ def add_file(
new_name = name or file.name
destination = self._files_location / new_name

if destination.exists():
Path(destination).chmod(0o700)

shutil.copy2(file, destination, follow_symlinks=True)
if permissions is not None:
Path(destination).chmod(0o400)
Path(destination).chmod(permissions)
self._files.append(new_name)


Expand Down
11 changes: 7 additions & 4 deletions tests/test_filesystem_dataset.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,12 +70,15 @@ def test_dataset_files_overwrite(filesystem_dataset, data_assets):
assert filesystem_dataset.has_file("example_file.dat")


def test_dataset_files_permissions(filesystem_dataset, data_assets):
filesystem_dataset.add_file(data_assets / "example_file.dat", permissions=0o400)
def test_dataset_files_read_only(filesystem_dataset, data_assets):
filesystem_dataset.add_file(data_assets / "example_file.dat")
assert filesystem_dataset.has_file("example_file.dat")

with pytest.raises(PermissionError):
filesystem_dataset.add_file(data_assets / "example_file.dat")
with (
pytest.raises(PermissionError),
filesystem_dataset.get_file("example_file.dat").open("w") as f,
):
f.write("test")


def test_dataset_files_rename(filesystem_dataset, data_assets):
Expand Down