Abstract Scope #3
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We set the options and then set all instance variables Added a nil refinement so that the system do not break with a nil parent
Added scoping methods
Change path normalization methods to class methods Use set accessor to access the set Return an empty hash for hash based scope properties if they are not supplied
Owner
Author
|
I guess once we're happy with the file and code organization and the classes and their hierarchy, I'll start work on improving performance. |
…iables if no argument is provided
MatchRoute is yet to be implemented
Because modules are a better way to share code instead of treating concrete classes as abstract when no such construct is supported by the language itself
Owner
Author
|
@pixeltrix Switched to a module for |
A bug in prefix_name_for_action prevented from proper route helper generation Added default_url_options
Fixed processing of to option and added root method
Append '/' only if child module exists along with parent module Added has_named_route? method Added some outline to match_route but we’ll leave that aside for the time being and replace the implementation in future after we get the whole thing working
It declares routes for a simple resource :single_resource declaration
This needs to be a separate class. Need to rethink resources
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We try to factor out common methods for a scope into the AbstractScope class.
It is yet unclear whether the Scope class should inherit from AbstractScope or if AbstractScope in itself suffices. This will only get clear when we start implementing resources. Right now we're trying to create an object graph which can generate non resourceful routes and is divided into small understandable files
\cc @pixeltrix