Fix logout cookie domain mismatch in OAuth mode#90
Merged
Conversation
The logout was hardcoding the cookie domain to Constants.PUBLIC_DOMAIN, while the login sets it from the request Host header. This caused the browser to receive an expired cookie for the wrong domain, leaving the original session cookie intact.
When a user logs in via interceptor mode (cookie on e.g. .feature.gcb-cloud.de) but navigates directly to /logout (detected as oauth mode), the cookie domain fell back to the host header instead of the tenant's interceptor cookieOrDomain. This caused the browser to ignore the Set-Cookie and keep the session alive. Now both logout branches check tenant.config.interceptor?.cookieOrDomain first, aligning with the login controller's setCookieDomain logic. Also adds the missing forwardInfo fallback to the interceptor branch. Includes unit test and e2e regression test for Egg wildcard tenant logout.
tklae
approved these changes
Feb 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Constants.PUBLIC_DOMAIN, while login sets it from the requestHostheader. This caused the browser to receive an expired cookie for the wrong domain (e.g.login.a.cominstead oflogin.b.com), leaving the original session cookie intact and the user still logged in after redirect.req.headers.first(name: "host")for OAuth mode, matching the login cookie domain logic.Test plan
login.a.com)HostmatchesPUBLIC_DOMAINLoginControllerLogoutTests)