Skip to content

fix uehaj2022 / latteart#12 #22

Open
dikshika-s wants to merge 1 commit intomainfrom
12-improve-ui-of-screen-sequence-and-transition-diagram
Open

fix uehaj2022 / latteart#12 #22
dikshika-s wants to merge 1 commit intomainfrom
12-improve-ui-of-screen-sequence-and-transition-diagram

Conversation

@dikshika-s
Copy link
Copy Markdown
Collaborator

@dikshika-s dikshika-s commented Nov 23, 2022

In #12 I did hardcode changes but I will create separate color file soon.

@uehaj2022
Copy link
Copy Markdown
Owner

First of all please change PR name.
to "fix uehaj2022 / latteart#NN" ("fix "+organization name+"/latteart#" + issue number)

where NN is a issue number of the issue list of uehaj2022/latteart repository.

@uehaj2022
Copy link
Copy Markdown
Owner

If you make changed to latteart-capture-cl or latteart-repositry, please make PR for each repositories.
and push them in each repositories.

@dikshika-s dikshika-s changed the title Change ui of diagram models fix uehaj2022 / latteart#12" Nov 25, 2022
@dikshika-s
Copy link
Copy Markdown
Collaborator Author

If you make changed to latteart-capture-cl or latteart-repositry, please make PR for each repositories. and push them in each repositories.

Sir no changes were made in the latteart-capture-cl and latteart-repositry, I will keep this in mind in future if I make changes to any of the two.
Thank You

@uehaj2022
Copy link
Copy Markdown
Owner

Sir no changes were made in the latteart-capture-cl and latteart-repositry, I will keep this in mind in future if I make changes to any of the two.

Thank you sir,

as our maintainance strategy of latteart repositories,
code for "latteart should" be in "latteart" repository,
code for "latteart-capture-cl" should be in "latteart-capture-cl" repository,
code for "latteart-repositry" should be in "latteart-repositry" repository.
but your PR looks
put code for "latteart-capture-cl" and "latteart-repositry" are both into "latteart" repository, right?
So, can you please remove files of "latteart-capture-cl" and "latteart-repositry" from this PR?

@GochaLearningSpace
Copy link
Copy Markdown
Collaborator

Sir no changes were made in the latteart-capture-cl and latteart-repositry, I will keep this in mind in future if I make changes to any of the two.

Thank you sir,

as our maintainance strategy of latteart repositories, code for "latteart should" be in "latteart" repository, code for "latteart-capture-cl" should be in "latteart-capture-cl" repository, code for "latteart-repositry" should be in "latteart-repositry" repository. but your PR looks put code for "latteart-capture-cl" and "latteart-repositry" are both into "latteart" repository, right? So, can you please remove files of "latteart-capture-cl" and "latteart-repositry" from this PR?

@dikshika-s CC: @uehaj2022
Did you confirm this message?
If so , please reply or make reaction.

@dikshika-s dikshika-s changed the title fix uehaj2022 / latteart#12" fix uehaj2022 / latteart#12 Dec 1, 2022
@dikshika-s dikshika-s force-pushed the 12-improve-ui-of-screen-sequence-and-transition-diagram branch from 918cc9e to 38dd21f Compare December 1, 2022 08:07
@dikshika-s
Copy link
Copy Markdown
Collaborator Author

Yes Sir I have removed the files , Sir for future commits could I add latteart-capture-cl and latteart-repository folders to .gitignore of latteart?

@uehaj2022
Copy link
Copy Markdown
Owner

Yes Sir I have removed the files , Sir for future commits could I add latteart-capture-cl and latteart-repository folders to .gitignore of latteart?

Thank you for your consideration.
Sorry for late reply. Yes it is no problem. Please add those folders on .gitignore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants