Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -124,4 +124,4 @@
"git add"
]
}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,8 @@
small
:title="$store.getters.message('app.autofill')"
>
<v-icon>edit</v-icon>
<v-icon v-if="isDisabled">edit</v-icon>
<v-icon v-else>drive_file_rename_outline</v-icon>
</v-btn>
</div>
</template>
Expand All @@ -43,10 +44,7 @@ export default class AutofillButton extends Vue {
private autofillConditionGroup: AutofillConditionGroup[] | null = null;

private get isDisabled(): boolean {
if (
!this.$store.state.captureControl.isCapturing ||
this.$store.state.captureControl.isAutoOperation
) {
if (!this.$store.state.captureControl.isCapturing) {
this.setMatchedAutofillConditionGroup(null);
return true;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
:disabled="isDisabled"
:title="$store.getters.message('navigate.back')"
>
<v-icon dark>arrow_back</v-icon>
<v-icon dark>chevron_left</v-icon>
</v-btn>
</div>
</template>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
:disabled="isDisabled"
:title="$store.getters.message('navigate.forward')"
>
<v-icon dark>arrow_forward</v-icon>
<v-icon dark>chevron_right</v-icon>
</v-btn>
</div>
</template>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
small
:title="$store.getters.message('app.record-note')"
>
<v-icon>add_comment</v-icon>
<v-icon>notes</v-icon>
</v-btn>

<note-edit-dialog
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,8 @@
:title="$store.getters.message('app.target-tab-window')"
id="openWindowSelectorButton"
>
<v-icon dark>tab</v-icon>
<v-icon v-if="windowSelectorIsEnabled">tab</v-icon>
<v-icon v-else>tab_unselected</v-icon>
</v-btn>

<window-selector-dialog
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ import MenuButton from "./MenuButton.vue";
},
})
export default class CaptureToolHeader extends Vue {
private cancelKeydown(event: Event) {
public cancelKeydown(event: Event) {
event.stopPropagation();
}
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,8 @@
@click="resetHistory"
:title="$store.getters.message('app.reset')"
>
<v-icon>refresh</v-icon>
<v-icon v-if="isDisabled">block</v-icon>
<v-icon v-else>autorenew</v-icon>
</v-btn>
</div>
</template>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,8 @@
:disabled="isDisabled"
:title="$store.getters.message('app.import')"
>
<v-icon>folder_open</v-icon>
<v-icon v-if="isDisabled">cancel_presentation</v-icon>
<v-icon v-else>cloud_circle</v-icon>
</v-btn>

<v-menu
Expand Down Expand Up @@ -58,7 +59,6 @@
<script lang="ts">
import { Component, Vue } from "vue-property-decorator";
import ErrorMessageDialog from "@/vue/pages/common/ErrorMessageDialog.vue";
import { TestResultSummary } from "@/lib/operationHistory/types";

@Component({
components: {
Expand All @@ -71,7 +71,7 @@ export default class LoadHistoryButton extends Vue {
private menuY = 0;
private errorMessageDialogOpened = false;
private errorMessage = "";
private testResults: Array<TestResultSummary> = [];
private testResults: Array<{ id: string; name: string }> = [];

private get isDisabled(): boolean {
return this.isCapturing || this.isReplaying || this.isResuming;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,8 @@
:title="pauseButtonTooltip"
:color="pauseButtonColor"
>
<v-icon>pause</v-icon>
<v-icon v-if="!isCapturing">pause</v-icon>
<v-icon v-else>pause_circle_outline</v-icon>
</v-btn>
</div>
</template>
Expand Down Expand Up @@ -53,7 +54,7 @@ export default class PauseButton extends Vue {
}

private get pauseButtonColor() {
return this.isPaused ? "yellow" : "grey darken-3";
return this.isPaused ? "red" : "grey darken-3";
}

private pushPauseButton() {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -27,19 +27,20 @@
:title="$store.getters.message('app.start')"
id="startButton"
>
<v-icon>fiber_manual_record</v-icon>
<v-icon v-if="isDisabled">block</v-icon>
<v-icon v-else>fiber_manual_record</v-icon>
</v-btn>
<v-btn
v-else
icon
flat
large
color="red"
color="green"
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We would like to know why you chose green. (For example, did you think green would be easier to understand, etc.)
If it is simply about your color preferences, then it would be better to make the colors customizable in the settings, because preferences can vary from user to user.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I choose green because the users more easily recognize it. I'll try to make it customizable in the settings instead of hard-coded.

@click="endCapture"
:title="$store.getters.message('app.finish')"
id="endButton"
>
<v-icon>fiber_manual_record</v-icon>
<v-icon color="green">fiber_smart_record</v-icon>
</v-btn>

<test-option-dialog
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@

<template>
<v-layout justify-start align-center row>
<v-icon class="pl-4 pr-1">save_alt</v-icon>
<v-icon class="pl-4 pr-1">input</v-icon>
<v-text-field
single-line
:label="$store.getters.message('app.test-result-name')"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,10 @@

<template>
<v-layout justify-start align-center row>
<v-icon class="pr-1">open_in_browser</v-icon>
<v-icon class="pr-1">add_link</v-icon>
<v-text-field
single-line
label="URL"
label="URL Link"
v-model="url"
:disabled="isDisabled"
id="urlTextField"
Expand Down
24 changes: 19 additions & 5 deletions tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -12,11 +12,23 @@
"esModuleInterop": true,
"allowSyntheticDefaultImports": true,
"baseUrl": ".",
"types": ["node", "webpack-env", "jest", "vuetify"],
"types": [
"node",
"webpack-env",
"jest",
"vuetify"
],
"paths": {
"@/*": ["src/gui/*"]
"@/*": [
"src/gui/*"
]
},
"lib": ["esnext", "dom", "dom.iterable", "scripthost"]
"lib": [
"esnext",
"dom",
"dom.iterable",
"scripthost"
]
},
"include": [
"src/gui/**/*.ts",
Expand All @@ -25,5 +37,7 @@
"tests/**/*.ts",
"tests/**/*.tsx"
],
"exclude": ["node_modules"]
}
"exclude": [
"node_modules"
]
}