Wrap contents of table header and table cell nodes in paragraph#45
Open
godismyjudge95 wants to merge 2 commits intoueberdosis:mainfrom
Open
Wrap contents of table header and table cell nodes in paragraph#45godismyjudge95 wants to merge 2 commits intoueberdosis:mainfrom
godismyjudge95 wants to merge 2 commits intoueberdosis:mainfrom
Conversation
nperez0111
force-pushed
the
fix-table-header-and-cell
branch
from
f90a949 to
3d9f156
Compare
nperez0111
force-pushed
the
fix-table-header-and-cell
branch
from
3d9f156 to
a5b1fd4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Importing tables from HTML causes the content of table cells to not be wrapped in paragraph tags which Tiptap js then complains is invalid content.
This takes the wrapper code from the TaskItem https://github.com/ueberdosis/tiptap-php/blob/main/src/Nodes/TaskItem.php#L71-L83 and applies it to the TableHeader and TableCell nodes as well.