Draft
Conversation
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Swap away from bitnami images for the valkey & valkey sentinel deployments.
The Valkey Sentinel docker image has been removed, but valkey sentinel can be deployed from the standard valkey image.
I would love feedback on this draft, primarily as it pertains to the
values/values.yaml. I do not love the new implementation. There is not an upstream helm chart that supports sentinel, except for the bitnami one that is currently being used.In the
values/values.yaml, I had to figure out how the bitnami startup scripts would create a sentinel.conf, then recreate it myself. I am open to suggestions on how this could better be implemented.Unfortunately, I had to continue using bitnamilegacy for the redis-exporter image, as bitnami has a hardcoded bash wrapper for the exporter, which only get's enabled whenever you enable sentinel. There are no upstream redis-exporter images that support a bash terminal.
Related Issue
Fixes #
Relates to #
Type of change
Checklist before merging