fix #8 issue. #9
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The problem was that after inserting a new planet the cursor updated instead of creating new cursor, then on the swapCursor function, the old cursor (which is also the new cursor) was closed and then when we tried to read the content out of the new cursor (also the old cursor) we got an exception since the cursor was closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem was that after inserting a new planet the cursor updated instead of creating new cursor, then on the swapCursor function, the old cursor (which is also the new cursor) was closed and then when we tried to read the content out of the new cursor (also the old cursor) we got an exception since the cursor was closed.
NOTE:
The real solution is to rebase this commit and squash it with the Starter_Code commit, but this action would affect all the users that using this repo, so I recommend each user to rebase this issue on it's local repo