Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Pulled template from here
Title
Textboxes are deleted when content is the same across all textboxes
Type of Change
Description
Added two new methods (compareAll() and removeTextboxes()) to TextboxesManager.ts. compareAll() is used in the update() function in the case when an edit is made inside a textbox, checking if the edit caused all textboxes to have the same content. If so, removeTextboxes() is called to delete textboxes visually and in memory, updating the template content and
Testing
I tested with smaller cases (~3 snippets) and with making changes to the textboxes across multiple snippets. I still need to test with special cases (empty textboxes, removals, complex edits) but first I need to address a bug where textboxes have incorrect ranges at times.
Impact
It will be easier for users to detect where diffs/parameters are in the snippets/templates now that old textboxes that have the same content are removed.
Additional Information
[Any additional information that reviewers should be aware of.]
Checklist