Skip to content

Jcs/duplicate user check #1373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jSylvestre merged 2 commits into from
Apr 3, 2025
Merged

Jcs/duplicate user check #1373

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c32cb2d
Extra check to make sure person isn't already in team
jSylvestre Apr 3, 2025
3bde896
show team and slug info (needed for most api calls)
jSylvestre Apr 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion Keas.Mvc/Controllers/Api/PeopleController.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -251,14 +251,22 @@ public async Task<IActionResult> Create([FromBody] Person person)
else
{
//Force lookup. Don't trust passed user
person.User = await _identityService.GetByKerberos(person.UserId);
user = await _identityService.GetByKerberos(person.UserId);
person.User = user;
}

if (person.User == null)
{
return NotFound();
}

//Need to have API call validated so it doesn't create a dup person
if(await _context.People.IgnoreQueryFilters().Where(a => a.TeamId == team.Id && a.UserId == user.Id).AnyAsync())
{
ModelState.AddModelError("UserId", "This user is already added to this team.");
return BadRequest(ModelState);
}

if (person.Supervisor != null)
{
_context.People.Attach(person.Supervisor);
Expand Down
5 changes: 3 additions & 2 deletions Keas.Mvc/Views/TeamAdmin/RegenerateApiCode.cshtml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,9 @@
@if (Model.TeamApiCode != null)
{
<div class="card-content">
<p><b>Current API Code:</b></p>
<p>@Html.DisplayFor(model => model.TeamApiCode.ApiCode)</p>
<div><b>Current API Code:</b> @Html.DisplayFor(model => model.TeamApiCode.ApiCode)</div>
<div><b>Team Slug:</b> @Model.Slug</div>
<div><b>Team Id:</b> @Model.Id</div>
</div>
}
<div style="padding: 19px 20px 20px;">
Expand Down