-
Notifications
You must be signed in to change notification settings - Fork 2
add preview flag for sf api to support multiple hasEmail #1000 #1002
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds preview flag support to the SiteFarm API to handle multiple hasEmail addresses for experts, addressing issue #1000. The implementation allows for backward compatibility by maintaining the existing API behavior while providing enhanced email support through a preview parameter.
- Extracts utility functions from the main API file to a dedicated utils.js module for better organization
- Implements preview format middleware that supports multiple email addresses for experts
- Updates OpenAPI documentation with both standard and preview schemas
Reviewed Changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 7 comments.
| File | Description |
|---|---|
| services/base-service/models/sitefarm/utils.js | New utility module containing extracted SiteFarm formatting functions and preview middleware |
| services/base-service/models/sitefarm/swagger.json | Updated OpenAPI schema with cleaner structure and version bump |
| services/base-service/models/sitefarm/swagger-preview.json | New preview schema documenting multiple email support |
| services/base-service/models/sitefarm/api.js | Refactored to use extracted utilities and added preview parameter routing logic |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
No description provided.