Deploy containers to Kubernetes#206
Closed
feynmanliang wants to merge 25 commits intoucbrise:developfrom
Closed
Conversation
|
Can one of the admins verify this patch? |
Closed
* develop: Wording fix (ucbrise#234) RPC container content fix (ucbrise#232) [CLIPPER-227] Fix EWMA behavior for meters (ucbrise#228) One-line app registration and model deployment (ucbrise#223) R model deployment (ucbrise#195) Allow model versions to be strings (ucbrise#197) Base64 decoding for JSON byte data (ucbrise#214) Restarting on containers is no longer the default behavior (ucbrise#213) fixed backslash escape issue for removing remote containers (ucbrise#210) removed pip install findspark from run_unittests.sh (ucbrise#211) Fix example code in README (ucbrise#205)
Contributor
Author
|
@dcrankshaw ready for review |
Contributor
|
I'm currently reviewing this. I'm actually refactoring it a bit and adding some additional functionality as well, which I will submit as a pull request to this branch. So let's treat this as basically a feature branch for now. From what I've looked at so far, this looks great. The functionality I'm adding is mostly refactoring the python package and adding plain Docker support so we don't break existing workflows when this gets merged. |
Contributor
|
Replaced by #251 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
minikubefor local developmentdocker-composedependency (all Clipper resources are provided on the k8s cluster)RemovesThe R container that was added (R model deployment #195) reintroduced thisfabricdependency (remote administration is done through K8s api nowClipperK8sclass to handle Kubernetes interfaceTo test:
minikubeClipper and its components should be deployed to minkube
Run
kubectl get svcto get the k8s service port mappings. Substitute in the corresponding values intoclipper_manager.py(this could be improved by making it a constructor argument)To deploy to clipper on k8s:
Test the endpoint by POSTing queries to
$(minikube ip):1337/hello_world/predictCluster resources can be deprovisioned with
clipper.stop_all()This change is