Make deploy_predict_function work without Anaconda environments#194
Make deploy_predict_function work without Anaconda environments#194dcrankshaw merged 6 commits intoucbrise:developfrom
Conversation
nishadsingh1
force-pushed
the
deploy_func_wo_conda
branch
from
ab627bf to
cdc5ea3
Compare
|
Test FAILed. |
nishadsingh1
force-pushed
the
deploy_func_wo_conda
branch
from
cdc5ea3 to
16806a1
Compare
|
Test FAILed. |
|
Jenkins failures relate to formatting; I'm still running into the problem of the hanging formatting script. I'll figure it out since it'll be needed a lot, but the code itself should be readable for review regardless |
dcrankshaw
changed the title
nishadsingh1
force-pushed
the
deploy_func_wo_conda
branch
from
16806a1 to
03d7965
Compare
|
Test PASSed. |
dcrankshaw
left a comment
dcrankshaw
left a comment
There was a problem hiding this comment.
This is failing for me with an ImportError: No module named clipper_admin.pywrencloudpickle
Also, can you print out the import error here: https://github.com/ucbrise/clipper/blob/develop/containers/python/python_container.py#L121
Something like:
except ImportError as e:
print("ImportError: %s" % e)
sys.exit(IMPORT_ERROR_RETURN_CODE)
clipper_admin/clipper_manager.py
Outdated
|
|
||
| print("Supplied environment details") | ||
| else: | ||
| print("Anaconda environment was either not found or failed being exported") |
There was a problem hiding this comment.
Rephrase to print("Anaconda environment was either not found or exporting the environment failed.")
| print("Anaconda environment was either not found or failed being exported") | ||
| print( | ||
| "Your local environment details will not be supplied to and loaded in the container in which your model is deployed." | ||
| ) |
There was a problem hiding this comment.
Rephrase to:
"Your function will still be serialized deployed, but may fail due to missing dependencies. In this case, please re-run inside an Anaconda environment. See http://clipper.ai/documentation/python_model_deployment/ for more information."
| dependency_check_returncode=$? | ||
|
|
||
| if [ $dependency_check_returncode -eq 0 ]; then | ||
| echo "Attempting to run Python container without installing without supplied dependencies." |
There was a problem hiding this comment.
Rephrase/fix typo: "First attempting to run Python container without installing supplied dependencies."
| fi | ||
| fi | ||
|
|
||
| echo "Encountered error not related to missing packages. Please refer to the above logs to diagnose." |
There was a problem hiding this comment.
rephrase: "Encountered error not related to missing packages. Please refer to the container logs to diagnose."
dcrankshaw
added
status: needs revision
type: enhancement
status: needs review
and removed
status: needs review
status: needs revision
labels
|
I did a bit of cleanup to make sure that this will work when the user installed |
|
Test FAILed. |
|
Test FAILed. |
|
Note that these jenkins tests were intentionally killed by me. |
dcrankshaw
force-pushed
the
deploy_func_wo_conda
branch
from
29a44ee to
c764965
Compare
|
Test PASSed. |
3 participants
Fixes #190
There's a ipython notebook with testcases. I think these could eventually be moved into python integration tests -- let me know what the best way to do this is would be (they require checking logs, waiting, etc).
We'd need to update this documentation when this PR goes through: ucbrise/clipper-website#2