Skip to content

fix: invocation proof order#202

Open
alanshaw wants to merge 1 commit intoucan-wg:mainfrom
alanshaw:ash/fix/inv-fixtures
Open

fix: invocation proof order#202
alanshaw wants to merge 1 commit intoucan-wg:mainfrom
alanshaw:ash/fix/inv-fixtures

Conversation

@alanshaw
Copy link
Contributor

@alanshaw alanshaw commented Feb 11, 2026

resolves #201

This PR fixes the proof order in valid invocation fixtures. It also adds a time field - a Unix timestamp in seconds at which the validation should occur.

refs alanshaw/ucantone#2

@cla-bot
Copy link

cla-bot bot commented Feb 11, 2026

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @alanshaw on file. In order for us to review and merge your code, please contact the project maintainers to get yourself added.

@Gozala
Copy link
Contributor

Gozala commented Feb 11, 2026

I'll integrate this into rs-ucan to verify it works as expected and provide feedback based on findings (I'm not good at parsing cbor in base64 encoded with my eyes 😅)

Copy link
Contributor

@Gozala Gozala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and rust implementation is in compliance with it now 🎉

Thanks @alanshaw

@Gozala Gozala force-pushed the ash/fix/inv-fixtures branch from ec5635c to b3e10ea Compare February 12, 2026 16:45
@cla-bot cla-bot bot added the cla-signed label Feb 12, 2026
@Gozala
Copy link
Contributor

Gozala commented Feb 12, 2026

@alanshaw I think branch protection rules prevent merges unless commits are signed, you may want to update your git config so it signs commits I'll amend this one to unblock and merge

@Gozala
Copy link
Contributor

Gozala commented Feb 12, 2026

@alanshaw I think branch protection rules prevent merges unless commits are signed, you may want to update your git config so it signs commits I'll amend this one to unblock and merge

Actually I can not do that because PR is from your repo and I don't have commit rights to it, so I think you may need to do this

@alanshaw alanshaw force-pushed the ash/fix/inv-fixtures branch 2 times, most recently from f5f7e4e to 9b0f988 Compare February 25, 2026 13:26
Signed-off-by: Alan Shaw <your_email@abc.example>
Signed-off-by: Alan Shaw <alan138@gmail.com>
@alanshaw alanshaw force-pushed the ash/fix/inv-fixtures branch from 9b0f988 to 2e5a6f9 Compare February 25, 2026 13:30
@alanshaw
Copy link
Contributor Author

@Gozala all good now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Issues with invocation fixtures

2 participants