Conversation
added idea of drawing board based on SurfaceView
…ng long board name and long username in BoardPreviewCard)
nbirillo
suggested changes
Dec 21, 2021
nbirillo
left a comment
nbirillo
left a comment
There was a problem hiding this comment.
В целом довольно неплохо, то есть самое основное - это сейчас огромная вложенность и в основном она потому что всякие настройки стилей не вынесены в темы или отдельные элементы, чтобы можно было просто их переиспользовать и их было легко менять
а так там незначительные мелочи
Comment on lines
+16
to
+20
| if (settingsStore.token == null) { | ||
| preferences.remove(TOKEN) | ||
| } else { | ||
| preferences[TOKEN] = settingsStore.token | ||
| } |
There was a problem hiding this comment.
старайтесь использовать более котлиновские конструкции, типа let, ?:
Comment on lines
+4
to
+5
| const val API_URL = "https://bebroo.bnt.to/api" | ||
| const val APP_URL = "https://bebroo.bnt.to/" |
Comment on lines
+246
to
+250
| text = stringResource(R.string.rename_board), | ||
| modifier = Modifier.padding(top = 15.dp).align(Alignment.CenterHorizontally), | ||
| fontSize = 25.sp, | ||
| fontWeight = FontWeight.Medium, | ||
| ) |
There was a problem hiding this comment.
ну обычно делают всякие обертки с темами и не настраивают элементы уже отдельно, чтоб это можно было легко править и сразу везде
| OutlinedTextField( | ||
| value = password, | ||
| onValueChange = { | ||
| if (it.length <= 100) { |
There was a problem hiding this comment.
такие штук лучше выносить в валидаторы, чтоб это было проще)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.