Simplify lexer interface, improve error messages#34
Open
xpmatteo wants to merge 2 commits intouberto:version_4_0from
Open
Simplify lexer interface, improve error messages#34xpmatteo wants to merge 2 commits intouberto:version_4_0from
xpmatteo wants to merge 2 commits intouberto:version_4_0from
Conversation
Replace character position tracking with line/column numbers in error messages for better usability. Previously errors reported "at position 38", now they report "at line 1, column 39" which is much easier to locate in source files. Changes: - Add Location data class to track line and column (both 1-indexed) - Update all KondorToken types to include location information - Change token separators from data objects to data classes to hold location - Update lexers to track line/column during tokenization - Simplify TokensStream by removing position tracking logic - Update parser error construction to use Location instead of Int position - Update all tests to reflect new error message format and token locations All 208+ tests pass across all modules (kondor-core, kondor-outcome, kondor-tools, kondor-auto, kondor-jackson, kondor-examples). 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Update README.md error message example to show new line/column format instead of character position. Add CHANGELOG entry for v4.0.0-beta2 documenting this improvement. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two improvements