-
Notifications
You must be signed in to change notification settings - Fork 14
Creation of Configuration Component #19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
| @@ -0,0 +1,11 @@ | |||
| .mat-slide-toggle.mat-checked { | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Didn't quite know where to add this global overwrite so I made a new file for it? Should we rather have a material.scss file for all global angular material overwrites? @ubergeoff
| <ng-container *ngIf="!!configComponent"> | ||
| <div | ||
| class="config-sliders" | ||
| rooiComponentConfig |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Allows for each example/component to have it's own configuration component
| styleUrls: ['./component-configuration.component.scss'] | ||
| }) | ||
| export class ComponentConfigurationComponent { | ||
| @Input() title: string | undefined; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for some reason ESLint wants these | undefined types. I don't like it though, should I update the eslint rules?
| @@ -0,0 +1,36 @@ | |||
| <div class="config-container"> | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not the most detailed example, but Angular Material's updating is sub-par tbh
| constructor(private matTableDemoService: MatTableDemoService) {} | ||
|
|
||
| toggleRowExpansion(): void { | ||
| this.componentConfiguration.enableRowExpansion = !this.componentConfiguration.enableRowExpansion; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To be updated. Angular Material table needs a force update to make this work. Do you know how to externally force an update?
| constructor(private matTableDemoService: MatTableDemoService) { | ||
| this.rowComponent = MatTableRowDemoComponent; | ||
| this.expandedRowComponent = MatTableExpansionRowDemoComponent; | ||
| // this.expandedRowComponent = MatTableExpansionRowDemoComponent; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To be removed
|
@GerritBurgerDev - Failing build..? Need some help..? |
|
Hey sorry got a little hectic first week will jump on it on Monday
…On Fri, 04 Feb 2022, 10:18 ubergeoff, ***@***.***> wrote:
@GerritBurgerDev <https://github.com/GerritBurgerDev> - Failing build..?
Need some help..?
—
Reply to this email directly, view it on GitHub
<#19 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AHFN2SL763G72U2JSBHKDFLUZODU5ANCNFSM5M5JKI3A>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Uh oh!
There was an error while loading. Please reload this page.