Export FakeFrame.Arg2KVIterator to faciliate tests#757
Open
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #757 +/- ##
==========================================
+ Coverage 88.21% 88.36% +0.14%
==========================================
Files 40 40
Lines 4074 4074
==========================================
+ Hits 3594 3600 +6
+ Misses 364 361 -3
+ Partials 116 113 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
devastating
reviewed
Aug 23, 2019
|
|
||
| arg2KVIterator arg2.KeyValIterator | ||
| Arg2KVIterator arg2.KeyValIterator | ||
| hasArg2KVIterator error |
Contributor
There was a problem hiding this comment.
I think you need to export hasArg2KVIterator as well.
Contributor
|
For someone creating a fake call frame, does it make more sense to provide a setter that takes a Similarly, should we merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With arg2KVIterator unexported, it is extremely difficult for consumers to test with call frames when arg2 is involved. This change simply exports that attr so that is is possible to supply a custom iterator, such as via
arg2.NewKeyValIterator.