Defer processing of elements that depend on generated code.#80
Merged
Leland-Takamine merged 1 commit intomasterfrom May 14, 2019
Merged
Defer processing of elements that depend on generated code.#80Leland-Takamine merged 1 commit intomasterfrom
Leland-Takamine merged 1 commit intomasterfrom
Conversation
Leland-Takamine
force-pushed
the
deferred-elements
branch
from
58a61b4 to
709daf8
Compare
kurtisnelson
approved these changes
May 14, 2019
tyvsmith
approved these changes
May 14, 2019
… on generated code.
Leland-Takamine
force-pushed
the
deferred-elements
branch
from
709daf8 to
74c2116
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, Motif's annotation processor would fail to recognize code generated superinterfaces/superclasses. Leverage BasicAnnotationProcessor to defer processing of elements that depend on generated code. Only add test for immediate superinterfaces for now. Once google/auto#733 lands and is deployed we'll update to the newest version of google/auto and add tests for grandparent superinterfaces.