Conversation
jbarr21
force-pushed
the
jb/2.1.0
branch
2 times, most recently
from
e0ad7e6 to
b38a02e
Compare
| if (isKotlinLibrary && isAndroidLibraryOrApp) { | ||
| android { | ||
| kotlinOptions { | ||
| jvmTarget = "1.8" |
There was a problem hiding this comment.
Do we still need to target 1.8?
There was a problem hiding this comment.
Could prolly target 11 since it's tooling, but trying to limit the scope of this already large change
| .build() | ||
| } | ||
|
|
||
| @OptIn(com.squareup.kotlinpoet.javapoet.KotlinPoetJavaPoetPreview::class) |
There was a problem hiding this comment.
Any idea where that file came from? I assume we need it cleaned up.
psteiger
left a comment
psteiger
left a comment
There was a problem hiding this comment.
Approved w/ some suggestions / questions
| compileSdkVersion: 33, | ||
| ci: 'true' == System.getenv('CI'), | ||
| minSdkVersion: 21, | ||
| targetSdkVersion: 30, |
There was a problem hiding this comment.
I know we're limiting scope of changes but should we follow up with a bump in target as well?
There was a problem hiding this comment.
it only affects samples & it had further changes that i didn't want to tackle
| ktlint: '0.41.0', | ||
| ktfmt: '0.23', | ||
| kotlin: '2.1.0', | ||
| ksp: '2.1.0-1.0.28', |
There was a problem hiding this comment.
Can we go 2.1.0-1.0.29? It just got out 2wks ago
There was a problem hiding this comment.
upstream bazel rules_kotlin are on 2.1.0-1.0.28, so i stick w/ that for now
| room: '2.1.0', | ||
| roomCompilerProcessing: '2.6.0-alpha02', | ||
| dokka: '1.9.10', | ||
| roomCompilerProcessing: '2.7.0-alpha13', |
There was a problem hiding this comment.
sadly no, this is most recent. it has the necessary set of deps to support the version of kotlin/ksp/jvmMetadata that we want
3 participants
Upgrade Kotlin libraries in Motif to support v2.1.0. Upgrading Kotlin required updating many transitive libraries. KtFmt was also applied to the whole repo.
Updated libraries: