Skip to content

Fix StackOverflowError on types with self-references #261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
psteiger wants to merge 1 commit into
base: main
Choose a base branch
from
+10 −2
Open

Fix StackOverflowError on types with self-references #261

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions compiler/ast/src/main/kotlin/com/uber/xprocessing/ext/XType.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -312,8 +312,16 @@ fun XType.isPrimitive(): Boolean {
}

private fun XType.hasCollectionType(): Boolean {
return this.typeElement?.name.orEmpty() in collectionTypes ||
typeArguments.any { it.hasCollectionType() }
val visited = mutableSetOf<XType>()
val queue = mutableListOf(this@hasCollectionType)
while (queue.isNotEmpty()) {
val type = queue.removeFirst()
if (type in visited) continue
if (type.typeElement?.name in collectionTypes) return true
visited.add(type)
queue.addAll(type.typeArguments)
}
return false
}

private val collectionTypes =
Expand Down