Revert clickable hyperlinks to diff IDs feature#304
Open
kilosculptor wants to merge 4 commits intouber:masterfrom
Open
Revert clickable hyperlinks to diff IDs feature#304kilosculptor wants to merge 4 commits intouber:masterfrom
kilosculptor wants to merge 4 commits intouber:masterfrom
Conversation
- Add PhutilConsoleFormatter class with formatHyperlink() method - Update ICFlowMonogramField to render clickable diff IDs (D123) - Uses OSC 8 terminal hyperlinks for supported terminals - Gracefully falls back to plain text in unsupported terminals - Configurable base URL via UBER_DIFFERENTIAL_BASE_URL environment variable - Defaults to https://code.uberinternal.com Users can now click on diff IDs in arc flow output to open them in browser.
- Add PhutilConsoleFormatterTestCase with tests for: - formatHyperlink() method with OSC 8 sequences - ANSI enable/disable functionality - Edge cases and format string methods - Text escaping/unescaping - Add ICFlowMonogramFieldTestCase with tests for: - Field key and configuration methods - Value rendering with and without hyperlinks - URL building and base URL configuration - Environment variable support - Edge cases and error conditions All tests pass and verify proper functionality of the clickable diff ID feature in arc flow output.
This reverts commit 34b0be2.
This reverts commit fad98b8.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR reverts the clickable diff IDs feature introduced in PR #303 due to reported issues.
Reverted Changes
What This Revert Does
Files Affected
Impact
Why This Revert?
This is a safety-first approach to quickly restore stable functionality while the original issue is investigated and resolved.
Note: This PR should be merged immediately if the clickable diff feature is causing production issues.