Fix ComponentizedBuilderTests and MultiStageComponentizedBuilderTests #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# 50-character subject line # # 72-character wrapped longer description. This should answer: # # * Why was this change necessary? # * How does it address the problem? # * Are there any side effects? # # Include a link to the ticket, if any. # # Add co-authors if you worked on this code with others: # # Co-authored-by: Full Name <email@example.com> # Co-authored-by: Full Name <email@example.com>
rbrovko
reviewed
Apr 29, 2025
| ], | ||
| dependencies: [ | ||
| .package(url: "https://github.com/ReactiveX/RxSwift", from: "6.5.0"), | ||
| .package(url: "https://github.com/mattgallagher/CwlPreconditionTesting.git", from: "2.2.2"), // for testTarget only |
Contributor
There was a problem hiding this comment.
Need add CwlPreconditionTesting to RIBs.podspec too.
s.test_spec 'Tests' do |test_spec|
test_spec.source_files = 'RIBsTests/**/*.swift'
test_spec.dependency 'CwlPreconditionTesting'
end
rudro
approved these changes
Apr 29, 2025
Collaborator
rudro
left a comment
rudro
left a comment
There was a problem hiding this comment.
we should talk about the pod spec thing, but rest looks good.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes unit-testing compilation issue described in #10
It adds https://github.com/mattgallagher/CwlPreconditionTesting as a test target dependency to catch
assertionFailureandfatalErrorcalls thrown inComponentizedBuilderand inMultiStageComponentizedBuilder.This opens up ability to add more unit-tests #5 and paves the way for CI/CD setup #9