Skip to content

feat(devtools): Add bootstrap nobuild option #458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ibgreen wants to merge 6 commits into
base: master
Choose a base branch
from
Open

feat(devtools): Add bootstrap nobuild option #458

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
183d3f8
feat(devtools): Add bootstrap nobuild option
ibgreen Mar 7, 2024
2dff3e3
wip
ibgreen Mar 7, 2024
7a9bacb
wip
ibgreen Mar 7, 2024
6d24f87
wip
ibgreen Mar 7, 2024
ad83adc
wip
ibgreen Mar 7, 2024
4c0a2b2
wip
ibgreen Mar 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions modules/dev-tools/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,8 +51,8 @@
"bin": {
"ocular-bootstrap": "./scripts/bootstrap.js",
"ocular-build": "./scripts/build.js",
"ocular-bundle": "./scripts/bundle.js",
"ocular-bump": "./scripts/bump.js",
"ocular-bundle": "./scripts/bundle.js",
"ocular-clean": "./scripts/clean.js",
"ocular-lint": "./scripts/lint.js",
"ocular-metrics": "./scripts/metrics.js",
Expand Down Expand Up @@ -99,10 +99,10 @@
"prettier-check": "2.0.0",
"tape": "^4.11.0",
"tape-promise": "^4.0.0",
"typescript": "^5.2.2",
"ts-node": "~10.9.0",
"ts-patch": "^3.1.2",
"tsconfig-paths": "^4.1.1",
"typescript": "^5.2.2",
"vite": "^4.0.1",
"vite-plugin-html": "^3.2.0"
},
Expand Down
6 changes: 4 additions & 2 deletions modules/dev-tools/scripts/bootstrap.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,5 +32,7 @@ else
yarn link $packageName
fi

# build the submodules
npm run build
# build the submodules unless `nobuild` argment is passed
if [[ ! "$1" = "nobuild" ]]; then
Copy link
Collaborator

@Pessimistress Pessimistress Apr 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • IMO skip-build would be clearer
  • Update docs?

npm run build
fi
5 changes: 4 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,5 +28,8 @@
},
"pre-commit": "pre-commit",
"pre-push": "pre-push",
"dependencies": {}
"volta": {
"node": "20.11.1",
"yarn": "1.22.21"
}
}