This repository was archived by the owner on May 4, 2021. It is now read-only.
Closed
Conversation
added 2 commits
December 2, 2019 12:14
Contributor
Author
|
#288 was reverted. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#288 partially fixed some issues when we use makisu just for the
extractcommand under non-root, but caused other issues like described in #291 .This change would stop makisu from manipulating symlink targets, and avoid all such issues. However, we still have to tackle this relative path problem again for hardlinks, which we are mostly avoiding today.