-
Notifications
You must be signed in to change notification settings - Fork 17
Supports the backend port being sent in the HAProxy send-state header #20
base: master
Are you sure you want to change the base?
Conversation
|
Can you rebase this on master so it can get the new tests I added? |
51d7cf2 to
3933da2
Compare
|
Rebased on master but my run of the tests indicates it's ok (waiting on travis CI) ..............Ran 60 tests in 1.227s OK |
|
it looks like travis is sort of broken (their status page says they're "degraded"). I'll check back on this in a couple of hours and hope that travis has fixed their issues. |
|
Heh, that's a lot of tornado versions. |
|
@Roguelazer, it looks like Travis is less broken now. Is there anything else I should do for this to be ready for merge? |
|
@Roguelazer gentle ping? |
|
Looks like Willy is cutting HAProxy 1.6-dev2 soon which is the feature freeze that included the needed change for this branch to be needed. Is there anything else I should do to make this ready for merge? |
|
+1 for getting this merged. |
When service ports are assigned dynamically, haproxy sends the port in the send-state header rather than in the healthcheck uri. This adds support for that. Also adds support for periods in service names.
3933da2 to
3c5ab54
Compare
|
|
When service ports are assigned dynamically, haproxy sends the port in the send-state header rather than in the healthcheck uri because there is no way to make the uri contain the dynamically generated port. This adds support for deducing the port number from that header if it is present.
This is only useful if running HAProxy with the following commit, which is not yet merged into a 1.5 release branch (although Willy said that he planned to pull it in): http://git.haproxy.org/?p=haproxy.git;a=commitdiff;h=514061c414080701cb046171041a2d00859660e8
Also adds support for periods in service names.