Skip to content
This repository was archived by the owner on Feb 23, 2021. It is now read-only.

Conversation

@jolynch
Copy link

@jolynch jolynch commented Apr 10, 2015

When service ports are assigned dynamically, haproxy sends the port in the send-state header rather than in the healthcheck uri because there is no way to make the uri contain the dynamically generated port. This adds support for deducing the port number from that header if it is present.

This is only useful if running HAProxy with the following commit, which is not yet merged into a 1.5 release branch (although Willy said that he planned to pull it in): http://git.haproxy.org/?p=haproxy.git;a=commitdiff;h=514061c414080701cb046171041a2d00859660e8

Also adds support for periods in service names.

@Roguelazer
Copy link
Contributor

Can you rebase this on master so it can get the new tests I added?

@jolynch jolynch force-pushed the support_send_state_port branch 2 times, most recently from 51d7cf2 to 3933da2 Compare April 21, 2015 20:05
@jolynch
Copy link
Author

jolynch commented Apr 21, 2015

Rebased on master but my run of the tests indicates it's ok (waiting on travis CI)

..............

Ran 60 tests in 1.227s

OK

@Roguelazer
Copy link
Contributor

it looks like travis is sort of broken (their status page says they're "degraded"). I'll check back on this in a couple of hours and hope that travis has fixed their issues.

@jolynch
Copy link
Author

jolynch commented Apr 21, 2015

Heh, that's a lot of tornado versions.

@jolynch
Copy link
Author

jolynch commented Apr 28, 2015

@Roguelazer, it looks like Travis is less broken now. Is there anything else I should do for this to be ready for merge?

@jolynch
Copy link
Author

jolynch commented May 8, 2015

@Roguelazer gentle ping?

@jolynch
Copy link
Author

jolynch commented Jun 3, 2015

Looks like Willy is cutting HAProxy 1.6-dev2 soon which is the feature freeze that included the needed change for this branch to be needed. Is there anything else I should do to make this ready for merge?

@jnb
Copy link

jnb commented Jun 11, 2015

+1 for getting this merged.

When service ports are assigned dynamically, haproxy sends the port in
the send-state header rather than in the healthcheck uri. This adds
support for that.

Also adds support for periods in service names.
@jolynch jolynch force-pushed the support_send_state_port branch from 3933da2 to 3c5ab54 Compare July 8, 2015 23:08
@CLAassistant
Copy link

CLAassistant commented Jun 27, 2019

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants