-
Notifications
You must be signed in to change notification settings - Fork 75
Wordwrap long legends #2128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
aestoltm
wants to merge
16
commits into
ubccr:main
Choose a base branch
from
aestoltm:wordwrap_long_legends
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Wordwrap long legends #2128
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1112d73 to
26d783c
Compare
…Export Update caused some issues
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Category:Metric Explorer
Metric Explorer / Usage
enhancement
Enhancement of the functionality of an existing feature
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Depends on PR #2127 . Will also require PRs on the various XDMoD modules (https://github.com/ubccr/xdmod-xsede/pull/1099 and ubccr/xdmod-appkernels#145).
Add word wrapping to long legend entries. Plotly JS does not support automatic word wrap on legends, therefore, we have to pragmatically determine the word wrap condition based on the chart div width (also including when we resize the browser window).
Before:

After:

Motivation and Context
Long legends were unviewable before, especially detrimental for exported charts
Tests performed
Tested on dev port
Checklist: