Conversation
There was a problem hiding this comment.
Nice job on your first pull request! There's just a couple of things I want to go through.
Housekeeping
- In the future, try to have more descriptive pull request names. Instead of
added torpedo plugin, make it something likeImplemented torpedo simulation in Gazebo. - Since this is related to a GitHub issue, link it with Closes #, where N is the issue number. In this case, this closes #22.
- In the future, make your branch names a bit more descriptive. For example,
Hank/torpedo_simulation. - When you create a pull request, try to add a high level overview of what you changed/added in the description.
Code
- The torpedo launcher is still skewed a bit.
- Something is causing steelhead to be lifted up. I believe it's because the torpedo launcher has collision.
- See other comments.
Also, we'll discuss this more at the meeting (don't make any major changes til then), but I think I miscommunicated exactly what I wanted you to do, which is my fault. If you ever feel confused about what needs to be added, please feel free to ping me or one of the other leads in discord.
| </link> | ||
| </model> | ||
|
|
||
| <!-- Steelhead AUV (ensure this model exists on your GAZEBO_MODEL_PATH) --> |
There was a problem hiding this comment.
Don't leave in AI comments like this
There was a problem hiding this comment.
There's no need to create another keyboard teleop launcher. Instead, you can just add to src/steelhead_teleop/steelhead_teleop/keyboard_teleop.py. (Firing the torpedoes and claw are actually already defined.)
There was a problem hiding this comment.
I'm not sure what these new worlds are for. If they are for your own personal testing, do not include them in pull requests.
2 participants
torpedo triggered on key P