Fix member id extraction and work with bookmarks#17
Open
isbear wants to merge 10 commits intouasi:masterfrom
Open
Fix member id extraction and work with bookmarks#17isbear wants to merge 10 commits intouasi:masterfrom
isbear wants to merge 10 commits intouasi:masterfrom
Conversation
> lib/pixiv/client.rb:57: warning: circular argument reference - member_id
If you have saved your cookie, on the next script run you'll get already logged-in page, so, you need to populate @member_id.
Now it uses double-quotes instead of single-quotes
Use data-src attribute instead of src, since src without JS points to trasparent.gif
Author
|
P.S. Sorry, I am not yet familiar enough with rspec to fix the tests as well. |
Original image may have jpg or png extensions, while resized images always have jpg extension, so we cannot use medium_image_url as a reference to create original image url.
Code was not updated to work with new image_url_components and produced garbage. Not sure, how the situation with file extensions, but at least the url components are valid.
I am not interested currently in investigating this form of media any further, so, I just added indicatior to skip these...
isbear
commented
Aug 12, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes for: