Update Rails to v8.1 #884

jefferya · 2025-11-06T22:38:02Z

No description provided.

jefferya · 2025-11-07T16:24:50Z

bin/ci

+#!/usr/bin/env ruby
+require_relative "../config/boot"
+require "active_support/continuous_integration"
+
+CI = ActiveSupport::ContinuousIntegration
+require_relative "../config/ci.rb"


New feature in Rails 8, this file is the default added by rails app:update

jefferya · 2025-11-07T16:27:30Z

bin/setup


 def system!(*args)
-  system(*args) || abort("\n== Command #{args} failed ==")
+  system(*args, exception: true) || abort("\n== Command #{args} failed ==")


I accepted suggestions by rails app:update and combined with existing.

jefferya · 2025-11-07T16:28:54Z

config/application.rb

-    # Ensuring that ActiveStorage routes are loaded before Comfy's globbing
-    # route. Without this file serving routes are inaccessible.
-    config.railties_order = [ActiveStorage::Engine, :main_app, :all]
-    config.exceptions_app = routes
-


Moved to make future runs of rails app:update easier.

jefferya · 2025-11-07T16:38:00Z

config/ci.rb

+# Run using bin/ci
+
+# frozen_string_literal: true
+
+CI.run do
+  step "Setup", "bin/setup --skip-server"
+
+  step "Style: Ruby", "bin/rubocop"
+
+  step "Security: Importmap vulnerability audit", "bin/importmap audit"
+
+  step "Tests: Rails", "bin/rails test"
+  step "Tests: System", "bin/rails test:system"
+  step "Tests: Seeds", "env RAILS_ENV=test bin/rails db:seed:replant"
+
+  # Optional: set a green GitHub commit status to unblock PR merge.
+  # Requires the `gh` CLI and `gh extension install basecamp/gh-signoff`.
+  # if success?
+  #   step "Signoff: All systems go. Ready for merge and deploy.", "gh signoff"
+  # else
+  #   failure "Signoff: CI failed. Do not merge or deploy.", "Fix the issues and try again."
+  # end
+end


I accepted suggestions by rails app:update. This is the default generated file for the new Rails CI feature.

jefferya · 2025-11-07T16:40:16Z

config/puma.rb

 #
 environment ENV.fetch("RAILS_ENV") { "development" }

 # This configuration file will be evaluated by Puma. The top-level methods that


I accepted suggestions by rails app:update.

jefferya · 2025-11-07T16:40:26Z

config/initializers/filter_parameter_logging.rb

 # Use this to limit dissemination of sensitive information.
 # See the ActiveSupport::ParameterFilter documentation for supported notations and behaviors.
 Rails.application.config.filter_parameters += [
-  :passw, :email, :secret, :token, :_key, :crypt, :salt, :certificate, :otp, :ssn


I accepted suggestions by rails app:update

jefferya · 2025-11-07T16:40:43Z

config/initializers/content_security_policy.rb

 #   config.content_security_policy_nonce_generator = ->(request) { request.session.id.to_s }
 #   config.content_security_policy_nonce_directives = %w(script-src style-src)
 #
+#   # Automatically add `nonce` to `javascript_tag`, `javascript_include_tag`, and `stylesheet_link_tag`


I accepted suggestions by rails app:update

jefferya · 2025-11-07T16:40:57Z

config/initializers/assets.rb

 # Add additional assets to the asset load path.
 # Rails.application.config.assets.paths << Emoji.images_path
 Rails.application.config.assets.paths << Rails.root.join("node_modules/bootstrap-icons/font")
-


I accepted suggestions by rails app:update

jefferya · 2025-11-07T16:41:25Z

config/environments/test.rb

-  # config.action_dispatch.show_exceptions = :rescuable
-  # Raise exceptions instead of rendering exception templates.
-  config.action_dispatch.show_exceptions = false
+  config.action_dispatch.show_exceptions = :rescuable


I accepted suggestions by rails app:update

jefferya · 2025-11-07T16:43:22Z

config/environments/development.rb

+  config.action_view.annotate_rendered_view_with_filenames = true

  # Uncomment if you wish to allow Action Cable access from any origin.
  # config.action_cable.disable_request_forgery_protection = true


I accepted suggestions by rails app:update and weaved in previous customizations.

jefferya · 2025-11-07T16:44:53Z

config/environments/production.rb

+  #
  # Skip DNS rebinding protection for the default health check endpoint.
  # config.host_authorization = { exclude: ->(request) { request.path == "/up" } }
 end


I accepted suggestions by rails app:update and weaved in previous customizations.

jefferya · 2025-11-07T17:33:52Z

config/environments/staging.rb

+  #
  # Skip DNS rebinding protection for the default health check endpoint.
  # config.host_authorization = { exclude: ->(request) { request.path == "/up" } }
 end


based off config/environments/production.rb with differences:

RAILS_LOG_LEVEL

report_deprecations

attributes_for_inspect

jefferya · 2025-11-24T19:59:27Z

db/schema.rb

+    t.integer "page_id", null: false
    t.datetime "updated_at", precision: nil, null: false
    t.index ["is_published"], name: "index_comfy_cms_translations_on_is_published"
    t.index ["locale"], name: "index_comfy_cms_translations_on_locale"


Rails 8.1 db:schema:dump: columns are now sorted alphabetically by name.

jefferya added 2 commits November 4, 2025 15:10

Update from Rails 7.2.x to 8.0.x; address #880

af9a23a

Bump rails from 8.0 to 8.1; address #880

ca7555f

jefferya mentioned this pull request Nov 7, 2025

[WIP] Replace Comfortable Mexican Sofa with Comfortable Media Surfer Gem; address #737 #885

Open

9 tasks

jefferya commented Nov 7, 2025

View reviewed changes

Remove duplicate in config and setup env fix.

b10f72e

jefferya force-pushed the jefferya/880_rails_8.1 branch from 052e3a1 to b10f72e Compare November 7, 2025 17:27

jefferya commented Nov 7, 2025

View reviewed changes

jefferya changed the title ~~[WIP] Update Rails to v8.1~~ Update Rails to v8.1 Nov 7, 2025

Rails 8.1 db:schema:dump: columns are now sorted alphabetically by name.

e8d7efd

jefferya commented Nov 24, 2025

View reviewed changes

jefferya mentioned this pull request Dec 3, 2025

Epic: 2025 Deferred Maintenance #898

Open

Update Rails to v8.1 #884

Are you sure you want to change the base?

Update Rails to v8.1 #884

Uh oh!

Conversation

jefferya commented Nov 6, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jefferya Nov 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jefferya Nov 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

jefferya Nov 7, 2025 •

edited

Loading

jefferya Nov 7, 2025 •

edited

Loading