Skip to content

Add hacky delay to stabilise waitlist test #743

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
goto-bus-stop merged 2 commits into from
Jan 12, 2026
Merged

Add hacky delay to stabilise waitlist test #743

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
42830af
Add hacky delay to stabilise waitlist test
goto-bus-stop Jan 12, 2026
8db29dd
dummy
goto-bus-stop Jan 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions test/waitlist.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import assert from 'assert';
import supertest from 'supertest';
import * as sinon from 'sinon';
import delay from 'delay';
import randomString from 'random-string';
import createUwave from './utils/createUwave.mjs';
import testSource from './utils/testSource.mjs';
Expand Down Expand Up @@ -81,6 +82,8 @@ describe('Waitlist', () => {
.expect(400);

await uw.test.connectToWebSocketAs(user);
// HACK: might stabilise tests? But really it indicates a bug/race condition
await delay(100);

await supertest(uw.server)
.post('/api/waitlist')
Expand Down