Skip to content

Conversation

@IzaZed
Copy link
Contributor

@IzaZed IzaZed commented Aug 5, 2024

Add these bindings (and python properties where appropriate) to EventInstance:

  • getCPUUsage
  • getPitch
  • setPitch
  • getReverbLevel
  • setReverbLevel
  • Release
  • getTimelinePosition
  • setTimelinePosition
  • getVolume
  • setVolume
  • isVirtual

@tyrylu
Copy link
Owner

tyrylu commented Aug 11, 2024

Why do you think having the get|set methods and the properties at the same time is beneficiary? Also, I know, I don't like it myself, but adding tests would be helpful as well.

@IzaZed
Copy link
Contributor Author

IzaZed commented Aug 18, 2024

ah, that was just for API completion, only using properties works just as well for me though
I'll remove the methods and add tests

@tyrylu
Copy link
Owner

tyrylu commented Aug 18, 2024

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants