feat(webapp): add an "add project" page #31
Conversation
This commit introduces the module `page/error.rs` that defines a few components to display various error in a uniform way.
W95Psp
force-pushed
the
lucas/add-project-page
branch
from
9013d69 to
a6806d2
Compare
W95Psp
force-pushed
the
lucas/add-project-page
branch
from
a6806d2 to
2a9e272
Compare
W95Psp
changed the base branch from
lucas/gather-errors-in-module
to
lucas/improve-request-action
This is useful to process the result of the `handle_request` within the server action, or to perform some side effect before returning.
This commit split the "Projects" component in two smaller ones, and get rid of the form to add a project. Instead, this commit introduces a separate page for creating projects.
W95Psp
force-pushed
the
lucas/add-project-page
branch
from
2a9e272 to
2f5f5bf
Compare
There was a problem hiding this comment.
I would remove the details from the options, this kind of implies that a flake will "just work" with Typhon, when actually we require the typhonProject attribute to be set. Similarly, a "legacy" project does not actually require a default.nix but a nix/typhon.nix.
|
Then I can add those details and even maybe link to the documentation, WDYT? |
| <ActionForm action> | ||
| <div class="header">"Add a project"</div> | ||
| <div class="header-description sep"> | ||
| "Add continuous integration with Typhon for an existing codebase. This project will be visible to anyone that have access to this Typhon instance." |
There was a problem hiding this comment.
How about "Import a project's declaration to Typhon. This project will be visible to anyone with access to this Typhon instance."?
|
Eg, "a flake with Typhon enabled", where Typhon enabled is a link to the doc, and similar for legacy |
Aesthetically, I would keep the options clean, and add a link to the documentation below, maybe with a comment like "To learn more about project declarations, visit the documentation at https://typhon-ci.org". |
|
Apart from my comments on the text to display, this is a really nice page :) |
pnmadelaine
changed the title
|
I just noticed, this PR seems to break the display of our very nice logo :( |
This commit splits the "Projects" component into two smaller ones, and gets rid of the form to add a project. Instead, this commit introduces a separate page for creating projects.