Tidy up cabal #7
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mniip
reviewed
Apr 18, 2025
Member
There was a problem hiding this comment.
Did you just copy it from air? Most of these aren't necessary here. Also this is an open source repo.
Contributor
Author
There was a problem hiding this comment.
Yup. Just copied from Air.
Contributor
Author
There was a problem hiding this comment.
Also this is an open source repo.
Uff... I was unaware of that fact. So are we at a stage to be keen on backwards compatibility and similar?
Member
There was a problem hiding this comment.
No I'm just saying leaking stuff like filenames or jira numbers might not be a good idea
Yuras
approved these changes
Apr 18, 2025
Contributor
Author
|
As it is a public package (surprise to me) I also scaffolded cabal.project and CI |
mniip
approved these changes
Apr 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.