Fixed asynchronous fail, completed async success #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

marcellourbani wants to merge 1 commit into tychota:master from marcellourbani:asynctest

marcellourbani commented Aug 7, 2019

Saw the help request in Readme :)

I also changed asynchronous_throwable_side_effect.ts not to call any URL: an unit test is supposed to:

not have any external dependency (i.e. a database, a webserver,...)
not have side effects
run as fast as possible

calling an URL violates 1 and 3, possibly 2 too

Cheers
Marcello


          Fixed asynchronous fail, completed async success

6ab8f99

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet