Improve logging to list unconverted ancestors of given commit SHA#857
Open
bjornbjornsson wants to merge 2 commits intotwosigma:masterfrom
Open
Improve logging to list unconverted ancestors of given commit SHA#857bjornbjornsson wants to merge 2 commits intotwosigma:masterfrom
bjornbjornsson wants to merge 2 commits intotwosigma:masterfrom
Conversation
Previously, stitch_util.js was logging the message `listing all unconverted ancestors of {commit_sha}`, but the unconverted ancestors weren't actually being logged. This PR puts the unconverted ancestors in the log and also logs how many unconverted ancestors there are.
shijinglu
reviewed
Mar 24, 2022
Shorten commit SHAs; truncate the message if it's over 1000 characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, stitch_util.js was logging the message
listing all unconverted ancestors of {commit_sha}, but the unconverted ancestors weren't actually being logged. This PR puts the unconverted ancestors in the log and also logs how many unconverted ancestors there are.