Skip to content

[WIP / do not merge] List deleted submodules in 'Changes not staged for commit' #849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
leahnp wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[WIP / do not merge] List deleted submodules in 'Changes not staged for commit' #849

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions node/lib/util/diff_util.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,10 +94,7 @@ function readDiff(diff) {
continue;
}

// Skip the all submodule changes; they're handled separately.
if (NodeGit.TreeEntry.FILEMODE.COMMIT !== file.mode()) {
result[path] = fileStatus;
}
result[path] = fileStatus;
}
return result;
}
Expand Down
5 changes: 1 addition & 4 deletions node/lib/util/print_status_util.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -220,9 +220,7 @@ exports.listSubmoduleDescriptors = function (status) {
// If it's been removed, there's nothing more to add.

if (null === index) {
staged.push(new StatusDescriptor(FILESTATUS.REMOVED,
subName,
"submodule"));
// Should have a "removed" status from parent repo
return; // RETURN
}

Expand All @@ -232,7 +230,6 @@ exports.listSubmoduleDescriptors = function (status) {
let stagedStatus = FILESTATUS.MODIFIED; // other choice is `ADDED`

if (sub.isNew()) {
stagedDetail += ", newly created";
stagedStatus = FILESTATUS.ADDED;
}

Expand Down
2 changes: 1 addition & 1 deletion node/lib/util/status_util.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -519,7 +519,7 @@ exports.getRepoStatus = co.wrap(function *(repo, options) {
assert.isArray(options.paths);
}
if (undefined === options.showMetaChanges) {
options.showMetaChanges = false;
options.showMetaChanges = true;
}
else {
assert.isBoolean(options.showMetaChanges);
Expand Down