forked from aws-amplify/aws-sdk-android
-
Notifications
You must be signed in to change notification settings - Fork 0
Feature/Fast-Forward to 2.11 #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
alevkov
wants to merge
125
commits into
master
Choose a base branch
from
feature/fast-forward-to-2-11
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
packageand -> package and
up with amazonaws.com.cn
…x was that encodeBase64 required its flags to be updated to include Base64.NO_PADDING)
China region should have a default domain of amazonaws.com.cn instead of amazonaws.com
…ue-315 Resolved issue aws-amplify#315
While creating CognitoUserPool instance using the awsConfiguration.json file with following description.
"CognitoUserPool": {
"Default": {
"PoolId": "xxxxxxxxxx",
"AppClientId": "xxxxxxxx",
"AppClientSecret": "",
"Region": "xxxx"
}
}
It will return appClientSecret as "" which is not checked in this file and cause crash in android application.
Closed the last quote in comment
Otherwise leak occurs on reconnection as follows. https://github.com/hirofumi/aws-sdk-android-ht-leak
* Problem: Publishing silently fails when client is reconnecting and offline queues are disabled. Fix: Allow application to handle republishing of failed messages OR enable offline queues by throwing an exception under these conditions.
…lify#612) * Fix reconnection failure upon network disconnect 1. Set default value for clean session mqtt option 2. Update mqttWebSocketURL to use HTTP Port * Update AwsIotEndpointUtility.java Remove unused variables * Use default value for clean session Use the default value for clean session option without setting it explicitly * Update AWSIotMqttManager.java * set default cleanSession to true
In EventRecorder.java class, when converting to Event to submit to Pinpoint, the Event payload is missing `attributes` due to lack of copying `attributes` from the AnalyticsEvent.
For beta testing the the documentation tagging, use a beta tag
Transform the folder layout to maven requirement
Changes order of variable declaration to ensure non-empty variables
- The native libraries have been changed to read from the jniLibs folder. - Trailing whitespace/typos removes. - Delete old documentation before adding new files to prevent removed classes from staying behind. - Add dependency for s3_release step on the buildforrelease to include the libs required.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.