This repository was archived by the owner on Jan 15, 2022. It is now read-only.
Path exclusion/inclusion filtering#105
Open
angadsingh wants to merge 2 commits intotwitter:masterfrom
Open
Conversation
added 2 commits
June 29, 2014 14:50
* Added logic to FileLister.pruneListBySize method to prune orphan job confs and renamed to just pruneList (+1 squashed commit)
Contributor
|
This is a great idea. Let me put some minor comments along with the code. |
Contributor
There was a problem hiding this comment.
these looks like some specific internal users you run in your environment.
We may have to leave this out of the generic setup and you may have to add that in your internal deployment yourself.
Alternatively we can see if this can be picked up from hrave-conf.xml so that the shell script and the config are separated.
|
Angad Singh seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ability to specify include and exclude substrings for job history files.
Also for this to work, added logic to FileLister.pruneListBySize method to prune orphan job confs and renamed to just pruneList