Exclude QuickFix from dectect#filetype function#23
Open
Nealium wants to merge 1 commit intotweekmonster:masterfrom
Open
Exclude QuickFix from dectect#filetype function#23Nealium wants to merge 1 commit intotweekmonster:masterfrom
Nealium wants to merge 1 commit intotweekmonster:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes conflict specifically with vim-qf's QuickFix functions. QuickFix, in general, should be skipped with this function
Issue could effect other Plugins in similar situations, but this commit only solves QuickFix.
Specs:
How to recreate
:copen+:cclose+:copen+:ccloseResult:
{x}_LoadFTPluginx changes based on whatever pidvim{v}\ftplugin.vimis in:scriptnameslegacy exe b:undo_ftpluginWith tinkering, using
:make, the error message [below] also shows upTheory:
When setting the filetype of QuickFix to
qfagain, it undoes all vim-qf's functions which causes vim-qf to crash.Seeing most Plugins are designed to define functions one time, Django-Plus should avoid inadvertently removing them; especially with QuickFix which is a special case
Notes of behavior
1) Opening
views.py2) Opening
QuickFixPoint:
This illustrates why the original
empty(a:filename)isn't catching the QuickFix.Sorry for the Duplicate :(