AG-891: Use Record for split screen input playout contents#461
Merged
KvelaGorrrrnio merged 3 commits intomainfrom Jan 7, 2026
Merged
Conversation
The playout content objects for split screen inputs were assigned to a list instead of a record. This caused issues when serializing them. E.g. inputPlayoutContents[4] = obj, would become '[null,null,null,null,obj]'.
…exhaustion vulnerability.
Coverage Report for tv2/alba-server
File Coverage
|
||||||||||||||||||||||||||||||||||||||
2 tasks
rana-tv2
approved these changes
Jan 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Note
Jira ticket: https://tv2cms.atlassian.net/browse/AG-891
This PR fixes the issue where inserting sources into an empty split screen box, other than the first one, crashes the Alba TV 2 server. The reason for this is a serialization-issue caused by a mismatch in types.
Alba server models the types for playout content for split screen inputs as a record, but the implementation uses arrays.
From this, the code
will be serialized to
Change description
The implementation is changed to using records instead of arrays.
Warning
This above change requires changes in Alba TV 2 server as that depends on the type to be a list - not a record.
Additionally, the playout content type attributes are marked as readonly as they are, and should, only be modified when created.
The package
qsis also fixated to>=6.14.1as to avoid the memory exhaustion DoS vulnerability found in previous versions.Checklist