AG-885: Add service metadata to logs#457
Merged
LindvedKrvang merged 5 commits intomainfrom Dec 22, 2025
Merged
Conversation
The workflow might have an error if we run it from a feature branch.
It extracts ENV variable information and creates a metadata object. The metadata additions added in this commit are service.name and service.version.
KvelaGorrrrnio
requested review from
LindvedKrvang,
RasmusAlbrektsen and
rana-tv2
Coverage Report for tv2/alba-server
File CoverageNo changed files found. |
KvelaGorrrrnio
changed the title
rana-tv2
approved these changes
Dec 16, 2025
LindvedKrvang
approved these changes
Dec 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Warning
This PR requires https://github.com/tv2/ag-github-actions/pull/26.
Warning
This PR has changes from #456.
Context
Note
Jira ticket: https://tv2cms.atlassian.net/browse/AG-885
In order to get our logs into DataDog via the Observability teams pipeline, we need to set the entries
service.nameandservice.versionin our logs.Change description
The PR updates the create revision build to look for the next CalVer version, such that the release version can be built into the Docker image. The Dockerfile is changed to expose the release version build argument as an environment variable to the application. And lastly, an ApplicationMetadataGenerator is added that extracts the service metadata and composes it into a metadata object that is registered on the top-most logger instance.
Warning
Running the Create Revision Build workflow from a feature branch will set the
RELEASE_VERSIONto an empty string.Checklist