Merge objects in alphabetical order for determinism #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #9, making armerge's output deterministic is generally valuable. The main thing breaking determinism was the random merge order of objects due to the use of
HashMap, which intentionally randomizes the order of entries. UsingBTreeMapinstead to always merge objects in alphabetical order helps maintain determinism.There are still some sources of nondeterminism, but those are easier to manage by the user of the tool. For example, if an input library contains several objects with the same name, then the merge order of those objects is still nondeterministic because of the random suffix added to object names. The user could ensure there are no identically named objects in a given input library prior to calling armerge.