updates to swift 3.0 and xcode 8.1#48
Conversation
|
|
||
| it("should be serialized") { | ||
| let expected = "[{\"kind\":\"Dog\",\"nickname\":\"Fluffy\",\"trick\":\"Rollover\"},{\"kind\":\"Cat\",\"nickname\":\"Purry\"}]" | ||
| let expected = "[{\"kind\":\"Dog\",\"nickname\":\"Fluffy\",\"trick\":\"Rollover\"},{\"kind\":\"Cat\",\"nickname\":\"Purry\",\"trick\":null}]" |
There was a problem hiding this comment.
Line Length Violation: Line should be 150 characters or less: currently 157 characters (line_length)
| :returns: The array as a JSON string. | ||
| */ | ||
| public func toJsonString(prettyPrinted: Bool = false) -> String? { | ||
| public func toJsonString(_ prettyPrinted: Bool = false) -> String? { |
There was a problem hiding this comment.
Valid Docs Violation: Documented declarations should be valid. (valid_docs)
| :returns: The array as JSON, wrapped in NSData. | ||
| */ | ||
| public func toJson(prettyPrinted: Bool = false) -> NSData? { | ||
| public func toJson(_ prettyPrinted: Bool = false) -> Data? { |
There was a problem hiding this comment.
Valid Docs Violation: Documented declarations should be valid. (valid_docs)
|
Thanks for the PR @tiagomartinho Can someone verify this? I haven't touched anything in Swift for over 2 years now. |
|
|
||
| it("should be serialized") { | ||
| let expected = "[{\"kind\":\"Dog\",\"nickname\":\"Fluffy\",\"trick\":\"Rollover\"},{\"kind\":\"Cat\",\"nickname\":\"Purry\"}]" | ||
| let expected = "[{\"kind\":\"Dog\",\"nickname\":\"Fluffy\",\"trick\":\"Rollover\"},{\"kind\":\"Cat\",\"nickname\":\"Purry\",\"trick\":null}]" |
There was a problem hiding this comment.
Line Length Violation: Line should be 150 characters or less: currently 157 characters (line_length)
|
|
||
| it("should be serialized") { | ||
| let expected = "[{\"kind\":\"Dog\",\"nickname\":\"Fluffy\",\"trick\":\"Rollover\"},{\"kind\":\"Cat\",\"nickname\":\"Purry\"}]" | ||
| let expected = "[{\"kind\":\"Dog\",\"nickname\":\"Fluffy\",\"trick\":\"Rollover\"},{\"kind\":\"Cat\",\"nickname\":\"Purry\",\"trick\":null}]" |
There was a problem hiding this comment.
Line Length Violation: Line should be 150 characters or less: currently 157 characters (line_length)
3 participants
I updated the project to Swift 3.0, however the serialisation of enum does not work.
I also updated the pod spec that had the invalid platform keyword.