Open
Conversation
Contributor
marcalexiei
commented
Jul 4, 2025
marcalexiei
commented
- closes Project maintenance: avoid auto merge when linting workflow is not successful #181
- re add windows-latest to tests
- create separate lint job in ci
- add dependabot groups
marcalexiei
commented
Jul 4, 2025
| matrix: | ||
| node-version: [20, 22, 24] | ||
| os: [ubuntu-latest] | ||
| os: [ubuntu-latest, windows-latest] |
Contributor
Author
There was a problem hiding this comment.
Hey @kibertoad,
I see you removed windows from CI in #184,
the run was failing due to an issue with linting.
I don't think that lint task should be executed in every node / os combination so I created a separate task.
marcalexiei
commented
Jul 4, 2025
Comment on lines
-28
to
-30
| - name: Install PeerDeps | ||
| run: npm i fastify zod | ||
|
|
Contributor
Author
There was a problem hiding this comment.
This shouldn't be needed, both zod and fastify are already present inside devDependencies:
fastify-type-provider-zod/package.json
Line 61 in f746da2
fastify-type-provider-zod/package.json
Line 68 in f746da2
marcalexiei
force-pushed
the
ci-lint-merge
branch
from
8fd49ee to
149fb79
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.