fix(types): use types from fastify instead of fastify/types/schema to avoid node resolution errors#172
Draft
marcalexiei wants to merge 2 commits intoturkerdev:mainfrom
Draft
fix(types): use types from fastify instead of fastify/types/schema to avoid node resolution errors#172marcalexiei wants to merge 2 commits intoturkerdev:mainfrom
fastify instead of fastify/types/schema to avoid node resolution errors#172marcalexiei wants to merge 2 commits intoturkerdev:mainfrom
Conversation
kibertoad
reviewed
Jun 15, 2025
| "@types/node": "^22.15.30", | ||
| "@vitest/coverage-v8": "^3.2.2", | ||
| "fastify": "^5.3.3", | ||
| "fastify": "^5.4.1", |
Collaborator
There was a problem hiding this comment.
peerDependency also needs to be bumped
Contributor
Author
There was a problem hiding this comment.
I was hesitant to bump the peerDependency for the following reason:
Currently, it specifies fastify ^5, and updating it would require a major version bump.
Since this change only affects TypeScript types and doesn't involve any runtime fixes I felt it wasn't worth triggering a major release for it.
No problem changing it though!
…` to avoid node resolution errors
marcalexiei
force-pushed
the
fix-resolution
branch
from
3e43ee5 to
39b546e
Compare
kibertoad
approved these changes
Jul 4, 2025
Contributor
Author
|
Still waiting on |
|
It looks like that PR has been merged and released :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fastify/types/schemaimports when using node resolution #171Warning