[pull] master from php:master#533
Merged
pull[bot] merged 11 commits intoturkdevops:masterfrom Nov 13, 2025
Merged
Conversation
The stubs say array so in debug mode we get a ZPP violation assertion and even by fixing the stubs the behaviour is not identical due to missing indirect handling. This indicates using objects was never done, thus use the correct ZPP specifier
* tree-wide: Replace `WRONG_PARAM_COUNT` by `ZEND_WRONG_PARAM_COUNT()` This is a direct alias. * tree-wide: Replace `ZEND_WRONG_PARAM_COUNT()` by its definition This macro was hiding control flow (the return statement) and thus was particularly unhygienic.
* PHP-8.3: dom: Fix missing NUL byte check on C14NFile()
* PHP-8.4: dom: Fix missing NUL byte check on C14NFile()
* PHP-8.5: dom: Fix missing NUL byte check on C14NFile()
…ead of 'H' This aligns the behaviour with what the stubs say. And even if one fixes the stubs the behaviour is not identical due to missing indirect handling. This indicates that using objects is never done, so do the easy fix of changing the ZPP specifier. Closes GH-20465
* PHP-8.3: sapi/phpdbg: use 'h' ZPP specifier instead of'H'
* PHP-8.4: sapi/phpdbg: use 'h' ZPP specifier instead of'H'
* PHP-8.5: sapi/phpdbg: use 'h' ZPP specifier instead of'H'
Consolidate userland functions to rely on a single implementation Split get_comparison functions into a reverse and a normal one Use bool type when applicable
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )