Open
Conversation
huiyiqun
requested changes
Jul 7, 2017
fishroom/web/chat_log.html
Outdated
| fishLogData.current_id++; | ||
| fishLogData.msgs.push(msg); | ||
| // Notification sending... | ||
| var noti_title = msg.sender + "sent a new message"; |
Member
There was a problem hiding this comment.
A space between sender and "sent a new message"?
fishroom/web/chat_log.html
Outdated
| fishLogData.msgs.push(msg); | ||
| // Notification sending... | ||
| var noti_title = msg.sender + "sent a new message"; | ||
| if (Notification.permission === "granted") { |
Member
There was a problem hiding this comment.
Check browser compatibility pls.
alert is too verbose, just ignore it.
huiyiqun
approved these changes
Jul 7, 2017
Member
|
@Page-David good job. |
Author
|
You are welcome, by the way, is this good to merge or improvement is in need? |
Member
|
Fair enough. I'm waiting for @bigeagle to merge. I have no access to the production environment. |
Author
|
Oh, thanks. |
Page-David
commented
Jul 7, 2017
fishroom/web/chat_log.html
Outdated
| fishLogData.current_id++; | ||
| fishLogData.msgs.push(msg); | ||
| // Notification sending... | ||
| var notification = 'New message from ' + msg.sender; |
Author
There was a problem hiding this comment.
抱歉，突然发现标题名和Notification实例名冲突了。
Author
|
Variable conflict solved. |
Member
Author
|
已知悉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
一点微小的代码，谢谢大家