Added more citations #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
S-Thaler
approved these changes
Jan 8, 2025
Contributor
S-Thaler
left a comment
S-Thaler
left a comment
There was a problem hiding this comment.
Great, thanks Paul! If we're already being more rigorous with citations, I would just drop in the 2022 paper as well.
chemtrain/trainers/trainers.py
Outdated
| The Relative Entropy Minimization procedurecoarse-graines potential | ||
| models by minimizing the relative entropy between the atomistic reference | ||
| and coarse-grained target canonical distributions [#Shell2008]_. |
Contributor
There was a problem hiding this comment.
Can you additionally add the 2022 relative entropy paper for people to easier find an application to NNPs?
Contributor
Author
There was a problem hiding this comment.
Okay, I added the paper to the RelativeEntropy trainer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
chemtrain.learn.difftre